Bugfix Pack

Bugfix Pack

An addon compiling various fixes to bugs in ToME4.

===== Bugs fixed by this addon =====

= Band of Protection =
Getting a Damage Shield or Psionic Damage Shield effect while Band of Protection's Steam Shield effect is active causes game-breaking errors. This addon fixes this and makes Steam Shield behave like the other two damage shield effects (gets overwritten by new damage shields).

= Quake hitting multiple times =
Quake performs knockback during projection, which can cause the same actor to be hit multiple times, depending on the order that squares are iterated over. This addon fixes Quake so that it can only hit each actor once.

= Proc bonuses/penalties with nested attacks =
Weapon attacks that happen during other weapon attacks (such as Flexible Combat and weapons with talents on hit or talents on crit) can result in proc damage bonuses from staves being applied to the wrong weapon's procs, and the proc penalty for ogres applying multiple times to a weapon's procs and failing to apply at all to other procs. This addon fixes this so that the proc bonus from staves/shields only applies to the staff/shield's procs, and so that the ogre proc penalty always applies once.

= Real-time Anomaly Meteors =
Actors can dodge meteors from Anomaly Meteor by moving out of the way within 1/6th of a second, real-time. This addon removes this real-time behaviour, making the game properly turn-based once again.

= Wild Speed, Step Up, etc. resource leak =
An engine bug causes timed effects like Wild Speed and Step Up (ones that stop when you use a talent or attack) to constantly increase the size of a table on the actor using them. On characters that use these talents heavily, this can bloat savegames. This addon fixes this bug.

= Snapshotting for many talents =
Many sustains and passives do not update their values after being activated, allowing you to "snapshot" values with high power and then continue to use those high values even after changing to e.g. equipment that gives less spellpower or mastery. This addon currently fixes snapshotting for the following talents:
- Abyssal Shield
- Acid Infusion
- Acidic Skin
- Acidic Soil
- Aim
- Antimagic Shield
- Arcane Feed
- Arcane Power
- Arcane Shield
- Augmentation
- Automated Cloak Tessellation
- Berserker
- Berserker Rage
- Blade Flurry
- Blood Fury
- Blur Sight
- Body of Fire
- Burning Wake
- Corrosive Nature
- Corrosive Slashes
- Crystalline Focus
- Dark Ritual
- Defensive Posture
- Deflect Projectiles
- Eldritch Infusion
- Elemental Harmony
- Essence of Speed
- Eternal Night
- Fiery Hands
- Flame Infusion
- Flame of Urh'Rok
- Forge Shield
- Frost Hands
- Frost Infusion
- Furnace
- Golden Age of Necromancy
- Gravity Locus
- Grim Shadow
- Grinding Shield
- Ice Core
- Infestation
- Keen Senses
- Lightning Infusion
- Living Lightning
- Lucid Dreamer
- Mitosis
- Molten Iron Blood
- Momentum
- Natural Acid
- Nature's Defiance
- Onslaught
- Overheat Saws
- Pace Yourself
- Precise Strikes
- Precision
- Psiblades
- Rapid Shot
- Reflective Skin
- Resilient Body
- Righteous Strength
- Rocket Boots
- Secrets of the Eternals
- Shadow Feed
- Shielding
- Shield Wall
- Shattering Impact
- Shock Hands
- Slow Motion
- Spellcraft
- Steam Powered Armour
- Stone Skin
- Striking Stance
- Tempest
- Tempest of Metal
- Total Thuggery
- Unstoppable Nature
- Uttercold
- Weapon of Light
- Weapon of Wrath
- Wildfire

Unfortunately, this is not all of the snapshottable talents in the game, but it's a start.
This addon also fixes the ability to snapshot tons of passives and sustains by using items with "Talent category bonus".

===== Compatibility =====
This addon overwrites the following functions:
- mod.class.Actor's removeModifierList
- Anomaly Meteor's action
- Aim's activate
- Aim's deactivate
- Antimagic Shield's on_damage
- Arcane Power's activate
- Blood Fury's activate
- Blood Fury's deactivate
- Blur Sight's activate
- Blur Sight's deactivate
- Defensive Posture's activate
- Defensive Posture's deactivate
- Keen Senses's activate
- Keen Senses's deactivate
- Precise Strikes's activate
- Precise Strikes's deactivate
- Quake's action
- Stone Skin's activate
- Stone Skin's deactivate

It should otherwise not be destructive.

===== Changelog =====
- Updated for ToME version 1.7.3; removed fixes that are no longer needed (Reckless Strike)

- Updated for ToME version 1.7.2; fixed Spellcraft

- Updated for ToME version 1.7.0; removed fixes that are no longer needed
- Fixed snapshotting for Eternal Night, Golden Age of Necromancy, Grim Shadow, and Pace Yourself
- Disabled Body of Stone snapshotting fix, due to it being unclear how the talent is intended to behave

- Now works with Infinite Dungeon again
- Fixed Quake being able to hit the same target multiple times
- Fixed Form and Function not affecting weapon damage

- Bug fix: the new implementations of Blood Fury and Keen Senses now work with Arcane Might
- Fixed Band of Protection causing errors and havoc if a talent granting a regular damage shield or psionic damage shield (such as Improved Gestalt) is used while it is active.
- Fixed ActorTemporaryEffects:removeEffect() failing to remove effect list entries from the actor; this fixes useless crap piling up in your savegame when you (and NPCs) use movement infusions and similar effects.
- Fixed Gardanion's prodigy point being stolen by the Sher-Tul High Priest putting it on
- Fixed proc bonuses/penalties with nested attacks

- Fixed yet another Eyal's Will snapshotting bug

- Fixed cloneCustom() breaking Corpathus and Wintertide (see http://forums.te4.org/viewtopic.php?f=42&t=50960 )
- Fixed Annihilator's flamethrower talents causing an error when used with double weapons such as The Long-Arm
- Made Psychic Crush work more like Forgery of Haze/Shadow Simulacrum/etc., only removing remove_on_clone timed effects and such. This fixes various issues with timed effects like Mucus and Corrosive Worm.

- Fixed Eyal's Will Psiblades error

- Generalized Possess aura/shield fix for other talents and timed effects

- Fixed possessing creatures with Mindslayer auras and shields

- Fixed 1.6 Possessor resource leaks and performance regressions
- Fixed Meteoric Crash mind crits

- Fixed Godfeaster fix

- This version is not compatible with savegames from older versions!
- Updated all bug fixes for ToME4 version 1.6.7
- Added a warning popup if addon version doesn't match ToME4 version
- Fixed Fearscape and Godfeaster boss death portals
- Fixed Tentacled Wings hitting multiple times
- Fixed Hammer Toss serialization
- Fixed Lock On working on out-of-range and out-of-sight targets
- Fixed "of mastery" and "of perfection" amulet egos from overwriting existing mastery
- No longer fixes early equilibrium failures for targeted talents (too destructive to compatibility). Sorry.
- No longer alters talents that had their bugs fixed in mainline ToME4: Bone Shield, Overkill, Willful Tormenter, Wing Buffet knockback
- Abyssal Shield melee retaliation restored (and no longer snapshottable)
- Flame of Urh'Rok original resistance formula restored (and no longer shapshottable)
- on_mastery_change functions added by other addons will no longer be stomped
- All original talent function environments are now preserved (improves compatibility with other addons)
- Fixed Reckless Strike so that it actually ignores resistances (instead of just giving 70% penetration)
- Restored Reckless Strike's "25% of damage dealt" alternative backlash, but made this amount of backlash damage actually correct (in mainline ToME4 it almost always inflicts less backlash than it should)
- Fixed snapshotting for more talents: Acid Infusion, Acidic Skin, Acidic Soil, Arcane Feed, Arcane Power, Arcane Shield, Augmentation, Automated Cloak Tessellation, Berserker, Berserker Rage, Blur Sight, Body of Fire, Body of Stone, Burning Wake, Corrosive Nature, Crystalline Focus, Deflect Projectiles, Eldritch Infusion, Elemental Harmony, Essence of Speed, Fiery Hands, Flame Infusion, Forge Shield, Frost Hands, Frost Infusion, Frostdusk, Furnace, Gravity Locus, Grinding Shield, Ice Core, Keen Senses, Lightning Infusion, Living Lightning, Lucid Dreamer, Mitosis, Molten Iron Blood, Momentum, Natural Acid, Nature's Defiance, Onslaught, Pace Yourself, Phantasmal Shield, Precision, Psiblades, Rapid Shot, Reflective Skin, Resilient Body, Righteous Strength, Rocket Boots, Secrets of the Eternals, Shadow Feed, Shattering Impact, Shielding, Shield Wall, Shock Hands, Slow Motion, Spellcraft, Steam Powered Armour, Stone Skin, Tempest, Tempest of Metal, Total Thuggery, Unstoppable Nature, Uttercold, Weapon of Light, Weapon of Wrath, Wildfire
- Fixed snapshotting via talents_mastery_bonus (e.g. the Radiance artifact cloak, the Adept prodigy)

- Fixed sustainbug for Aim, Antimagic Shield, Striking Stance
- Fixed Antimagic Shield's retaliation
- Fixed Blast and Wing Buffet hitting multiple times
- Preserved original fenv for more replaced functions, to reduce the chances of addon conflicts

- Gave the Spider talent's action its original fenv back (fixes some artifacts)

- Remove Catalepsy fix as it is fixed in vanilla in 1.5.8

- Fixed Catalepsy

- Fixed equilibrium failure happening before targeting instead of after.

- Shifted to a generalized bugfix addon instead of just "Meteor Fix".
- Fixed sustainbug for Abyssal Shield, Blood Fury, Bone Shield, Corrosive Slashes, Dark Ritual, Defensive Posture, Flame of Urh'Rok, Infestation, Overkill, Precise Strikes, Willful Tormenter
- Fixed Reckless Strike self-kills
- Fixed Reckless Strike damage shield interaction
- Reckless Strike now always damages you for 30% of your current HP after the attack
- Overkill now correctly attributes its damage to the talent
- Overkill now ignores the source's inc_damage instead of the victim's
- Overkill now projects its damage in an onTickEnd()
- Overkill no longer has an overzealous recursion guard, just a regular recursion guard

- Initial release

Weight: 61428967

Bugfix Pack forum discussion thread
See addon usage in the character's vault.
Your rating: None Average: 5 (2 votes)

is this going to be

is this going to be upstreamed?